Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade base image #666

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Upgrade base image #666

merged 3 commits into from
Jan 15, 2025

Conversation

Taepper
Copy link
Collaborator

@Taepper Taepper commented Dec 18, 2024 •
edited
Loading

resolves #663

Summary

The base image was still at ubuntu:22.04. Upgrading this gives us access to a newer compiler version

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.
- [ ] The implemented feature is covered by an appropriate test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

There is no change in the changelog. This PR will not produce a new releasable version.

@Taepper
Copy link
Collaborator Author

Taepper commented Jan 6, 2025

Installing conan with pipx works seamlessly, however it is installed under ~/. local/bin, which is not in $PATH by default. Running the recommended pipx ensurepath would add it to $PATH but a new shell would need to be started, which we would need to do from the Dockerfile itself? For now I specify the full path to the conan binary instead.

@Taepper Taepper force-pushed the 663-upgrade-base-image branch 2 times, most recently from ed1a357 to 2820237 Compare January 8, 2025 07:20
@Taepper Taepper force-pushed the 663-upgrade-base-image branch from 2aaf721 to d963308 Compare January 8, 2025 14:03
fengelniederhammer
fengelniederhammer requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Let's just rework the commit messages:

  • "fix: correctly specify and copy the conanprofile for arm architectures" doesn't need to be a fix. This doesn't affect any released artifact.
  • The other "fix: install conan with pipx instead of pip" can maybe simply be squashed into the feat commit? We don't need this separately in the changelog.

@Taepper Taepper mentioned this pull request Jan 14, 2025
Merged
@Taepper Taepper force-pushed the 663-upgrade-base-image branch from d963308 to 2dc6af5 Compare January 14, 2025 16:28
@Taepper Taepper force-pushed the 663-upgrade-base-image branch from 2dc6af5 to 1629ba0 Compare January 15, 2025 08:33
@fengelniederhammer
Copy link
Contributor

I'm wondering why it shows "There is no change in the changelog. This PR will not produce a new releasable version."

Maybe we need to generate the missed release again by hand?

@Taepper
Copy link
Collaborator Author

Taepper commented Jan 15, 2025

Ah, I also caught that, but was confused. Your point might be the right approach

fengelniederhammer
fengelniederhammer approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and see whether Release Please is able to handle it. We can still generate the missed release by hand.

@Taepper Taepper merged commit 6a6d455 into main Jan 15, 2025
8 checks passed
@Taepper Taepper deleted the 663-upgrade-base-image branch January 15, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengelniederhammer fengelniederhammer fengelniederhammer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update base-image version to ubuntu:24.04
2 participants
@Taepper @fengelniederhammer